Page MenuHomePhabricator
Differential D16588

Give Phragment a sort of tetris block thing as a title glyph
ClosedPublic
Actions

Authored by epriestley on Sep 22 2016, 10:08 PM.
Tags
None
Referenced Files
F14065951: D16588.diff
Tue, Nov 19, 7:21 AM
F14055593: D16588.diff
Sat, Nov 16, 1:40 PM
F14041201: D16588.diff
Mon, Nov 11, 4:38 PM
F14031971: D16588.diff
Sat, Nov 9, 12:26 PM
F14027414: D16588.diff
Fri, Nov 8, 7:07 AM
F13995978: D16588.diff
Wed, Oct 23, 5:05 PM
F13978920: D16588.id39930.diff
Oct 19 2024, 1:40 AM
F13964428: D16588.id.diff
Oct 15 2024, 8:24 PM
View All Files
Subscribers
avivey
hach-que

Details

Reviewers
avivey
chad
Maniphest Tasks
T11679: Phragment has invalid (non-UTF8) title glyph
Commits
rPa799d0a89332: Give Phragment a sort of tetris block thing as a title glyph
Summary

Fixes T11679. This application is probably vanishing into the aether eventually, but stop it from fataling for now.

Here's the glyph: ▛

It's like a fragment of a block of file data! Right? Obviously.

Test Plan

Visited /phragment/ with glpyhs on, saw the glyph.

Diff Detail

Repository
rP Phabricator
Branch
phrag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13816
Build 17857: Run Core Tests
Build 17856: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39930.Sep 22 2016, 10:08 PM
epriestley retitled this revision from to Give Phragment a sort of tetris block thing as a title glyph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11679: Phragment has invalid (non-UTF8) title glyph.
Herald added a subscriber: hach-que. · View Herald TranscriptSep 22 2016, 10:08 PM
avivey accepted this revision.Sep 22 2016, 10:12 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

This looks hi-pri, must fix asap.

This revision is now accepted and ready to land.Sep 22 2016, 10:12 PM
Closed by commit rPa799d0a89332: Give Phragment a sort of tetris block thing as a title glyph (authored by epriestley, committed by epriestley). · Explain WhySep 22 2016, 10:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phragment/
application/
2 lines

Diff 39930

View Options

src/applications/phragment/application/PhabricatorPhragmentApplication.php

Loading...
Phabricator · Built by Phacility