Differential D16520

Add a very basic ICS syntax parser
ClosedPublic
Actions

Authored by epriestley on Sep 8 2016, 8:49 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU0107c187b6d8: Add a very basic ICS syntax parser

Summary

Ref T10747. Extremely rough parser for ICS syntax, based on RFC5545 + RFC6868.

This doesn't understand any of the content in an ICS file or know anything about calendaring or events yet, it just applies all the weird linewrapping, escaping, typing and parsing rules.

I'll refine this to be less bad and eventually do useful things, but I got a basic test case running at least.

Test Plan

Added unit test.
Ran unit test.

Diff Detail

Repository

rPHU libphutil

Branch

ics1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/calendar/ics/PhutilICSParser.php:353	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 13641
Build 17582: Run Core Tests
Build 17581: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39758.Sep 8 2016, 8:49 PM

epriestley retitled this revision from to Add a very basic ICS syntax parser.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 8 2016, 9:04 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2016, 9:04 PM

Closed by commit rPHU0107c187b6d8: Add a very basic ICS syntax parser (authored by epriestley, committed by epriestley). · Explain WhySep 9 2016, 12:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

14 lines

parser/

calendar/

data/

PhutilCalendarContainerNode.php

30 lines

PhutilCalendarDocumentNode.php

12 lines

PhutilCalendarEventNode.php

8 lines

PhutilCalendarNode.php

20 lines

PhutilCalendarRawNode.php

8 lines

ics/

PhutilICSParser.php

535 lines

__tests__/

PhutilICSParserTestCase.php

80 lines

data/

simple.ics

10 lines

Diff 39758

View Options

src/__phutil_library_map__.php

View Options

src/parser/calendar/data/PhutilCalendarContainerNode.php

View Options

src/parser/calendar/data/PhutilCalendarDocumentNode.php

View Options

src/parser/calendar/data/PhutilCalendarEventNode.php

View Options

src/parser/calendar/data/PhutilCalendarNode.php

View Options

src/parser/calendar/data/PhutilCalendarRawNode.php

View Options

src/parser/calendar/ics/PhutilICSParser.php

View Options

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

View Options

src/parser/calendar/ics/tests/data/simple.ics

Add a very basic ICS syntax parserClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39758

src/__phutil_library_map__.php

src/parser/calendar/data/PhutilCalendarContainerNode.php

src/parser/calendar/data/PhutilCalendarDocumentNode.php

src/parser/calendar/data/PhutilCalendarEventNode.php

src/parser/calendar/data/PhutilCalendarNode.php

src/parser/calendar/data/PhutilCalendarRawNode.php

src/parser/calendar/ics/PhutilICSParser.php

src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php

src/parser/calendar/ics/__tests__/data/simple.ics

Add a very basic ICS syntax parser
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

src/parser/calendar/ics/tests/data/simple.ics