Resolves T11520
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T11520: Arc Lint - Severity configuration behaves differently for different linters
Previewed the file in an editor window to make sure it looks good.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- nf_fix_lint_docs_for_text_severity
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13471 Build 17320: arc lint + arc unit
Event Timeline
Comment Actions
I think a better fix here is to accept either "TXT3" or "3" as keys. I'd rather do that than just document the current not-so-good behavior.
Generally, see T10038 for discussion. I think T3914 has some discussion of this issue in particular, although it is quite old.
Offhand, T8474, T9626, T4287 are also somewhat related.
In a vacuum, this patch is fine, but in the long term it's something we'd likely have to undo when we improve linter behavior. I don't plan to tackle any of this until the next major iteration on lint, which will probably occur after T4287/T11429 and alongside T5055 coming online.