Page MenuHomePhabricator
Differential D16446

Added application name to the typeahead results for doc type search
ClosedPublic
Actions

Authored by jcox on Aug 24 2016, 10:11 PM.
Tags
None
Referenced Files
F15511278: D16446.diff
Thu, Apr 17, 12:53 AM
F15450060: D16446.id39551.diff
Fri, Mar 28, 1:39 PM
F15442412: D16446.id39551.diff
Wed, Mar 26, 11:18 PM
F15437071: D16446.diff
Tue, Mar 25, 5:20 PM
F15431640: D16446.diff
Mon, Mar 24, 1:41 PM
F15400851: D16446.id.diff
Mar 17 2025, 2:18 PM
F15380371: D16446.id.diff
Mar 14 2025, 2:44 AM
F15377826: D16446.diff
Mar 13 2025, 10:56 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10951: Search shows document types corresponding to disabled apps
Commits
rPd135b3f2d56f: Added application name to the typeahead results for doc type search
Summary

Ref T10951. This adds the application name as an attribute below the document type in the UI for doc type search.

Test Plan

Verify that the application name appears as an attribute on the document type results.

Diff Detail

Repository
rP Phabricator
Branch
AddAppNameToDocTypeResults
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13437
Build 17265: Run Core Tests
Build 17264: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39551.Aug 24 2016, 10:11 PM
jcox retitled this revision from to Added application name to the typeahead results for doc type search.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T10951: Search shows document types corresponding to disabled apps.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2016, 10:11 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Aug 25 2016, 2:21 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Aug 25 2016, 2:21 PM
jcox updated this revision to Diff 39561.Aug 25 2016, 3:16 PM
jcox edited edge metadata.

Made line shorter

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2016, 3:16 PM
Closed by commit rPd135b3f2d56f: Added application name to the typeahead results for doc type search (authored by jcox, committed by jcox). · Explain WhyAug 25 2016, 3:26 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D16459: Converted the pinned applications selector to a typeahead..Aug 26 2016, 5:22 PM

Revision Contents
Changeset List

PathSize
src/
applications/
search/
typeahead/
20 lines

Diff 39561

View Options

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php

Loading...
Phabricator · Built by Phacility