Differential D16445

Remove unused apps from the DocumentType typeahead
ClosedPublic
Actions

Authored by jcox on Aug 24 2016, 9:44 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10951: Search shows document types corresponding to disabled apps

Commits

rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead

Summary

Ref T10951. This diff removes uninstalled applications from the result set for DocumentType restults

Test Plan

Uninstall an application (diviner for example), then go to the document type search menu and ensure that the uninstalled application doesn't show up.

Diff Detail

Repository

rP Phabricator

Branch

RemoveUnusedAppsFromSearch (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13434
Build 17260: Run Core Tests
Build 17259: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39550.Aug 24 2016, 9:44 PM

jcox retitled this revision from to Remove unused apps from the DocumentType typeahead.

jcox updated this object.

jcox edited the test plan for this revision. (Show Details)

jcox added a task: T10951: Search shows document types corresponding to disabled apps.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2016, 9:44 PM

Herald added a subscriber: epriestley. · View Herald Transcript

jcox added inline comments.Aug 24 2016, 9:45 PM

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
30–31	Is there a syntactically correct way to make this shorter without renaming things?

epriestley added inline comments.Aug 24 2016, 10:50 PM

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
30–31	Haha, does this fit? $types = Blahblahblah::blahblah( $blahblahblah);

Made a line shorter

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
31	lol yep. just barely!

Glorious.

This revision is now accepted and ready to land.Aug 25 2016, 2:20 PM

Closed by commit rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead (authored by jcox, committed by jcox). · Explain WhyAug 25 2016, 3:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

typeahead/

PhabricatorSearchDocumentTypeDatasource.php

4 lines

Diff 39558

View Options

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php

Remove unused apps from the DocumentType typeaheadClosedPublicActions