Page MenuHomePhabricator
Differential D16445

Remove unused apps from the DocumentType typeahead
ClosedPublic
Actions

Authored by jcox on Aug 24 2016, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 25, 8:53 PM
Unknown Object (File)
Fri, Feb 21, 3:50 PM
Unknown Object (File)
Fri, Feb 21, 3:50 PM
Unknown Object (File)
Wed, Feb 19, 4:28 AM
Unknown Object (File)
Tue, Feb 18, 11:38 AM
Unknown Object (File)
Thu, Feb 13, 3:15 AM
Unknown Object (File)
Sun, Feb 9, 2:14 AM
Unknown Object (File)
Sun, Feb 9, 2:14 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10951: Search shows document types corresponding to disabled apps
Commits
rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead
Summary

Ref T10951. This diff removes uninstalled applications from the result set for DocumentType restults

Test Plan

Uninstall an application (diviner for example), then go to the document type search menu and ensure that the uninstalled application doesn't show up.

Diff Detail

Repository
rP Phabricator
Branch
RemoveUnusedAppsFromSearch (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php:30TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 13426
Build 17247: Run Core Tests
Build 17246: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39550.Aug 24 2016, 9:44 PM
jcox retitled this revision from to Remove unused apps from the DocumentType typeahead.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T10951: Search shows document types corresponding to disabled apps.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2016, 9:44 PM
Herald added a subscriber: epriestley. · View Herald Transcript
jcox added inline comments.Aug 24 2016, 9:45 PM
src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
30

Is there a syntactically correct way to make this shorter without renaming things?

epriestley added inline comments.Aug 24 2016, 10:50 PM
src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
30

Haha, does this fit?

$types =
  Blahblahblah::blahblah(
    $blahblahblah);
jcox updated this revision to Diff 39558.Aug 25 2016, 1:04 PM
jcox edited edge metadata.
  • Made a line shorter
src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
31

lol yep. just barely!

epriestley accepted this revision.Aug 25 2016, 2:20 PM
epriestley added a reviewer: epriestley.

Glorious.

This revision is now accepted and ready to land.Aug 25 2016, 2:20 PM
Closed by commit rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead (authored by jcox, committed by jcox). · Explain WhyAug 25 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
typeahead/
3 lines

Diff 39550

View Options

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php

Loading...
Phabricator · Built by Phacility