Page MenuHomePhabricator

When a commit has a "rewritten" hint, show it in the UI instead of the generic "deleted" message
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:59 PM.
Tags
None
Referenced Files
F20347036: D16436.diff
Fri, Jun 12, 12:08 AM
F20332600: D16436.id39542.diff
Thu, Jun 11, 6:16 PM
Unknown Object (File)
Mon, Jun 1, 5:52 AM
Unknown Object (File)
Apr 7 2026, 7:36 AM
Unknown Object (File)
Apr 7 2026, 7:36 AM
Unknown Object (File)
Feb 1 2026, 8:27 AM
Unknown Object (File)
Jan 5 2026, 6:12 AM
Unknown Object (File)
Nov 7 2025, 12:29 PM
Subscribers
None

Details

Summary

Ref T11522. When a commit is no longer reachable from any branch/tag, we currently show a "this has been deleted" message.

Instead, go further: check if there is a "rewritten" hint pointing at a commit the current commit was rewritten into. If we find one, show a message about that instead.

(This isn't super pretty, just getting it working for now. I expect to revisit this UI in T9713 if we don't get to it before that.)

Test Plan

Screen Shot 2016-08-24 at 5.55.21 AM.png (1×1 px, 208 KB)

Diff Detail

Repository
rP Phabricator
Branch
hint3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13403
Build 17211: Run Core Tests
Build 17210: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When a commit has a "rewritten" hint, show it in the UI instead of the generic "deleted" message.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 4:03 PM
This revision was automatically updated to reflect the committed changes.