Page MenuHomePhabricator

Migrate the "badcommit" table to use the less-hacky "hint" mechanism
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 15, 9:55 PM
Unknown Object (File)
Mon, Jun 15, 4:04 PM
Unknown Object (File)
Mon, Jun 15, 4:04 PM
Unknown Object (File)
May 28 2026, 12:38 PM
Unknown Object (File)
Apr 2 2026, 9:31 AM
Unknown Object (File)
Mar 29 2026, 12:45 PM
Unknown Object (File)
Mar 9 2026, 7:42 PM
Unknown Object (File)
Mar 8 2026, 1:33 AM
Subscribers
None

Details

Summary

Ref T11522. This migrates any "badcommit" data (which probably only exists at Facebook and on 1-2 other installs in the wild) to the new "hint" table.

Test Plan
  • Wrote some bad commit annotations to the badcommit table.
  • Viewed them in the web UI and used bin/repository reparse --change ... to reparse them. Saw "this is bad" messages.
  • Ran migration, verified that valid "badcommit" rows were successfully migrated to become "hint" rows.
  • Viewed the new web UI and re-parsed the change, saw "unreadable commit" messages.
  • Viewed a good commit; reparsed a good commit.

Diff Detail

Repository
rP Phabricator
Branch
hint2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13402
Build 17209: Run Core Tests
Build 17208: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Migrate the "badcommit" table to use the less-hacky "hint" mechanism.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:56 PM
This revision was automatically updated to reflect the committed changes.