Page MenuHomePhabricator

Migrate the "badcommit" table to use the less-hacky "hint" mechanism
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:35 PM.
Tags
None
Referenced Files
F15462517: D16435.id39526.diff
Tue, Apr 1, 3:37 PM
F15447581: D16435.id39541.diff
Fri, Mar 28, 12:40 AM
F15447580: D16435.id39526.diff
Fri, Mar 28, 12:40 AM
F15447579: D16435.id.diff
Fri, Mar 28, 12:40 AM
F15442565: D16435.diff
Wed, Mar 26, 11:48 PM
F15427397: D16435.diff
Sun, Mar 23, 2:11 PM
F15418104: D16435.id39541.diff
Thu, Mar 20, 8:53 PM
F15418103: D16435.id.diff
Thu, Mar 20, 8:53 PM
Subscribers
None

Details

Summary

Ref T11522. This migrates any "badcommit" data (which probably only exists at Facebook and on 1-2 other installs in the wild) to the new "hint" table.

Test Plan
  • Wrote some bad commit annotations to the badcommit table.
  • Viewed them in the web UI and used bin/repository reparse --change ... to reparse them. Saw "this is bad" messages.
  • Ran migration, verified that valid "badcommit" rows were successfully migrated to become "hint" rows.
  • Viewed the new web UI and re-parsed the change, saw "unreadable commit" messages.
  • Viewed a good commit; reparsed a good commit.

Diff Detail

Repository
rP Phabricator
Branch
hint2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13402
Build 17209: Run Core Tests
Build 17208: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Migrate the "badcommit" table to use the less-hacky "hint" mechanism.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:56 PM
This revision was automatically updated to reflect the committed changes.