Page MenuHomePhabricator

Migrate the "badcommit" table to use the less-hacky "hint" mechanism
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:35 PM.
Tags
None
Referenced Files
F18942993: D16435.diff
Nov 11 2025, 1:03 PM
F18812637: D16435.id39526.diff
Oct 20 2025, 10:57 AM
F18745648: D16435.id.diff
Oct 3 2025, 8:35 AM
F18684976: D16435.diff
Sep 26 2025, 10:18 AM
F18645957: D16435.id39541.diff
Sep 19 2025, 8:53 AM
F18614066: D16435.id39526.diff
Sep 14 2025, 12:01 PM
F18601719: D16435.id39541.diff
Sep 13 2025, 1:17 PM
F18600333: D16435.id.diff
Sep 13 2025, 9:31 AM
Subscribers
None

Details

Summary

Ref T11522. This migrates any "badcommit" data (which probably only exists at Facebook and on 1-2 other installs in the wild) to the new "hint" table.

Test Plan
  • Wrote some bad commit annotations to the badcommit table.
  • Viewed them in the web UI and used bin/repository reparse --change ... to reparse them. Saw "this is bad" messages.
  • Ran migration, verified that valid "badcommit" rows were successfully migrated to become "hint" rows.
  • Viewed the new web UI and re-parsed the change, saw "unreadable commit" messages.
  • Viewed a good commit; reparsed a good commit.

Diff Detail

Repository
rP Phabricator
Branch
hint2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13402
Build 17209: Run Core Tests
Build 17208: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Migrate the "badcommit" table to use the less-hacky "hint" mechanism.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:56 PM
This revision was automatically updated to reflect the committed changes.