Page MenuHomePhabricator

Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine
ClosedPublic

Authored by epriestley on Aug 14 2016, 1:46 PM.
Tags
None
Referenced Files
F13285265: D16395.id39428.diff
Mon, Jun 3, 5:49 PM
F13275959: D16395.diff
Fri, May 31, 5:23 AM
F13250590: D16395.id39428.diff
Fri, May 24, 3:24 PM
F13221326: D16395.diff
Sun, May 19, 2:31 AM
F13192525: D16395.id.diff
Sun, May 12, 8:34 AM
Unknown Object (File)
Tue, May 7, 7:25 AM
Unknown Object (File)
May 3 2024, 6:14 AM
Unknown Object (File)
May 1 2024, 11:33 AM
Subscribers
Restricted Owners Package
Tokens
"Y So Serious" token, awarded by michaeljs1990.

Details

Summary

Ref T11473. When running harbormaster.build.search with a buildables constraint, the constraint doesn't get passed to the Query and so currently has no effect.

This piece of logic was just accidentally omitted from D16356. It is probably not used anywhere today and doesn't show up in the UI, so it's easy to overlook (I missed it in review, too).

Test Plan

Ran harbormaster.build.search with a buildables constraint, got expected filtering.

Diff Detail

Repository
rP Phabricator
Branch
build1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13309
Build 17067: Run Core Tests
Build 17066: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
Owners added a subscriber: Restricted Owners Package.Aug 14 2016, 1:46 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.