Page MenuHomePhabricator

Fix scrollbar in filetree sidenav
ClosedPublic

Authored by chad on Aug 12 2016, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 3:28 PM
Unknown Object (File)
Wed, Nov 27, 4:08 AM
Unknown Object (File)
Nov 20 2024, 7:03 PM
Unknown Object (File)
Nov 19 2024, 3:06 PM
Unknown Object (File)
Nov 14 2024, 11:48 PM
Unknown Object (File)
Nov 11 2024, 6:24 AM
Unknown Object (File)
Nov 10 2024, 4:04 PM
Unknown Object (File)
Nov 7 2024, 12:52 PM
Subscribers

Details

Summary

Fixes T11457, I guess. It feels wierd when you drag it a bit, and Im not positive if it's the calc css or javascript.

Test Plan

Enable filetree, shorten browser, see scrolling appear if files too long.

Diff Detail

Repository
rP Phabricator
Branch
filetree (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13300
Build 17056: Run Core Tests
Build 17055: arc lint + arc unit

Event Timeline

chad retitled this revision from to Fix scrollbar in filetree sidenav.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, avivey.
epriestley edited edge metadata.

Feels pretty reasonable to me in Safari on Desktop, at least.

This revision is now accepted and ready to land.Aug 12 2016, 12:18 AM
This revision was automatically updated to reflect the committed changes.