Fix scrollbar in filetree sidenav
ClosedPublic
Actions

Authored by chad on Aug 12 2016, 12:12 AM.

Details

Reviewers

epriestley
avivey

Maniphest Tasks

T11457: Can't scroll filetree in revision

Commits

rP2ea4e160bb9a: Fix scrollbar in filetree sidenav
rP07ea4e6f74e2: Fix scrollbar in filetree sidenav

Summary

Fixes T11457, I guess. It feels wierd when you drag it a bit, and Im not positive if it's the calc css or javascript.

Test Plan

Enable filetree, shorten browser, see scrolling appear if files too long.

Diff Detail

Repository

rP Phabricator

Branch

filetree (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13300
Build 17056: Run Core Tests
Build 17055: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39424.Aug 12 2016, 12:12 AM

chad retitled this revision from to Fix scrollbar in filetree sidenav.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, avivey.

chad added a task: T11457: Can't scroll filetree in revision.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 12 2016, 12:12 AM

Feels pretty reasonable to me in Safari on Desktop, at least.

This revision is now accepted and ready to land.Aug 12 2016, 12:18 AM

Closed by commit rP07ea4e6f74e2: Fix scrollbar in filetree sidenav (authored by chad, committed by chad). · Explain WhyAug 12 2016, 12:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

aphront/

phabricator-nav-view.css

6 lines

Diff 39424

View Options

resources/celerity/map.php