Page MenuHomePhabricator

Record the last time a connection was used on the connection object
ClosedPublic

Authored by epriestley on Aug 11 2016, 3:52 PM.
Tags
None
Referenced Files
F14843074: D16388.id39415.diff
Sun, Feb 2, 3:39 AM
F14843073: D16388.id.diff
Sun, Feb 2, 3:39 AM
Unknown Object (File)
Jan 3 2025, 5:55 PM
Unknown Object (File)
Dec 30 2024, 5:53 PM
Unknown Object (File)
Dec 30 2024, 4:23 PM
Unknown Object (File)
Dec 25 2024, 11:12 PM
Unknown Object (File)
Dec 22 2024, 8:23 AM
Unknown Object (File)
Dec 21 2024, 8:16 AM
Subscribers
None

Details

Summary

Ref T11458. Currently, we're very aggressive about closing connections.

I want to change things so we only close connections we haven't used recently (for example: no activity in the last 15 seconds). This should let us do a better job of holding open approximately only the connections we actually need in a wider range of cases.

Test Plan

Ran some code that uses queries.

This doesn't do anything on its own; see next diff in Phabricator for meaningful changes.

Diff Detail

Repository
rPHU libphutil
Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13289
Build 17039: Run Core Tests
Build 17038: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Record the last time a connection was used on the connection object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 6:17 PM
This revision was automatically updated to reflect the committed changes.