Page MenuHomePhabricator

Record the last time a connection was used on the connection object
ClosedPublic

Authored by epriestley on Aug 11 2016, 3:52 PM.
Tags
None
Referenced Files
F15457043: D16388.id39412.diff
Sun, Mar 30, 1:57 PM
F15456043: D16388.id39415.diff
Sun, Mar 30, 6:37 AM
F15454081: D16388.id.diff
Sat, Mar 29, 4:13 PM
F15451902: D16388.diff
Sat, Mar 29, 12:29 AM
F15438562: D16388.id.diff
Wed, Mar 26, 1:33 AM
F15419475: D16388.id39412.diff
Fri, Mar 21, 6:21 AM
F15415506: D16388.diff
Thu, Mar 20, 6:18 AM
F15404489: D16388.id39412.diff
Tue, Mar 18, 7:57 AM
Subscribers
None

Details

Summary

Ref T11458. Currently, we're very aggressive about closing connections.

I want to change things so we only close connections we haven't used recently (for example: no activity in the last 15 seconds). This should let us do a better job of holding open approximately only the connections we actually need in a wider range of cases.

Test Plan

Ran some code that uses queries.

This doesn't do anything on its own; see next diff in Phabricator for meaningful changes.

Diff Detail

Repository
rPHU libphutil
Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13289
Build 17039: Run Core Tests
Build 17038: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Record the last time a connection was used on the connection object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 6:17 PM
This revision was automatically updated to reflect the committed changes.