Page MenuHomePhabricator

Record the last time a connection was used on the connection object
ClosedPublic

Authored by epriestley on Aug 11 2016, 3:52 PM.
Tags
None
Referenced Files
F18817371: D16388.id.diff
Tue, Oct 21, 3:05 PM
F18814160: D16388.diff
Mon, Oct 20, 9:55 PM
F18723417: D16388.diff
Sep 30 2025, 12:49 AM
F18652589: D16388.id39415.diff
Sep 21 2025, 8:42 AM
F18647566: D16388.id.diff
Sep 19 2025, 1:29 PM
F18637384: D16388.id39415.diff
Sep 17 2025, 7:19 AM
F18631064: D16388.id.diff
Sep 16 2025, 2:06 PM
F18629461: D16388.diff
Sep 16 2025, 8:54 AM
Subscribers
None

Details

Summary

Ref T11458. Currently, we're very aggressive about closing connections.

I want to change things so we only close connections we haven't used recently (for example: no activity in the last 15 seconds). This should let us do a better job of holding open approximately only the connections we actually need in a wider range of cases.

Test Plan

Ran some code that uses queries.

This doesn't do anything on its own; see next diff in Phabricator for meaningful changes.

Diff Detail

Repository
rPHU libphutil
Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13289
Build 17039: Run Core Tests
Build 17038: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Record the last time a connection was used on the connection object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 6:17 PM
This revision was automatically updated to reflect the committed changes.