Page MenuHomePhabricator

Record the last time a connection was used on the connection object
ClosedPublic

Authored by epriestley on Aug 11 2016, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 9:50 PM
Unknown Object (File)
Sat, Sep 21, 5:42 AM
Unknown Object (File)
Tue, Sep 17, 7:57 PM
Unknown Object (File)
Sun, Sep 15, 7:16 PM
Unknown Object (File)
Fri, Sep 13, 4:31 AM
Unknown Object (File)
Fri, Sep 13, 4:18 AM
Unknown Object (File)
Fri, Sep 13, 4:17 AM
Unknown Object (File)
Fri, Sep 13, 4:17 AM
Subscribers
None

Details

Summary

Ref T11458. Currently, we're very aggressive about closing connections.

I want to change things so we only close connections we haven't used recently (for example: no activity in the last 15 seconds). This should let us do a better job of holding open approximately only the connections we actually need in a wider range of cases.

Test Plan

Ran some code that uses queries.

This doesn't do anything on its own; see next diff in Phabricator for meaningful changes.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Record the last time a connection was used on the connection object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 6:17 PM
This revision was automatically updated to reflect the committed changes.