Page MenuHomePhabricator

Use --no-ext-diff in `arc land` call to `git diff`
ClosedPublic

Authored by epriestley on Aug 6 2016, 1:41 PM.
Tags
None
Referenced Files
F12828492: D16375.id39379.diff
Thu, Mar 28, 10:51 AM
Unknown Object (File)
Feb 21 2024, 3:55 AM
Unknown Object (File)
Jan 20 2024, 12:03 AM
Unknown Object (File)
Dec 28 2023, 4:59 AM
Unknown Object (File)
Dec 24 2023, 2:15 PM
Unknown Object (File)
Dec 17 2023, 7:20 AM
Unknown Object (File)
Dec 1 2023, 1:06 AM
Unknown Object (File)
Nov 30 2023, 1:24 AM
Subscribers
None

Details

Summary

Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan

Will land this change.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use --no-ext-diff in `arc land` call to `git diff`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.