Page MenuHomePhabricator

Use --no-ext-diff in `arc land` call to `git diff`
ClosedPublic

Authored by epriestley on Aug 6 2016, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 12, 12:06 AM
Unknown Object (File)
Fri, Aug 12, 12:06 AM
Unknown Object (File)
Fri, Aug 12, 12:06 AM
Unknown Object (File)
Sun, Aug 7, 9:16 AM
Unknown Object (File)
Sat, Jul 23, 5:05 AM
Unknown Object (File)
Tue, Jul 19, 11:23 AM
Unknown Object (File)
Mon, Jul 18, 5:01 PM
Unknown Object (File)
Sun, Jul 17, 7:14 AM
Subscribers
None

Details

Summary

Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan

Will land this change.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use --no-ext-diff in `arc land` call to `git diff`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.