Page MenuHomePhabricator

Use --no-ext-diff in `arc land` call to `git diff`
ClosedPublic

Authored by epriestley on Aug 6 2016, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 10, 7:34 AM
Unknown Object (File)
Sat, May 28, 3:25 AM
Unknown Object (File)
May 23 2022, 4:42 AM
Unknown Object (File)
Apr 16 2017, 1:31 AM
Unknown Object (File)
Mar 13 2017, 4:44 PM
Unknown Object (File)
Feb 9 2017, 8:26 AM
Unknown Object (File)
Jan 30 2017, 4:17 PM
Unknown Object (File)
Jan 3 2017, 9:56 AM
Subscribers
None

Details

Summary

Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan

Will land this change.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use --no-ext-diff in `arc land` call to `git diff`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.