Page MenuHomePhabricator

Use --no-ext-diff in `arc land` call to `git diff`
ClosedPublic

Authored by epriestley on Aug 6 2016, 1:41 PM.

Details

Summary

Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan

Will land this change.

Diff Detail

Repository
rARC Arcanist
Branch
noex1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/land/ArcanistGitLandEngine.php:184XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 13255
Build 16991: Run Core Tests
Build 16990: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use --no-ext-diff in `arc land` call to `git diff`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.