Use long array syntax for compatibility instead of short array syntax
ClosedPublic
Actions

Authored by epriestley on Aug 1 2016, 12:08 PM.

Details

Reviewers

yelirekim
chad

Maniphest Tasks

T11409: harbormaster.buildquery fatals on short array syntax in older PHP

Commits

rP5380d877921e: Use long array syntax for compatibility instead of short array syntax

Summary

Fixes T11409. This syntax isn't compatible with older PHP.

Test Plan

Ran arc lint on the file.

Diff Detail

Repository

rP Phabricator

Branch

shortarray

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13220
Build 16938: Run Core Tests
Build 16937: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39340.Aug 1 2016, 12:08 PM

epriestley retitled this revision from to Use long array syntax for compatibility instead of short array syntax.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, yelirekim.

epriestley added a task: T11409: harbormaster.buildquery fatals on short array syntax in older PHP.

Owners added a subscriber: Restricted Owners Package.Aug 1 2016, 12:08 PM

chad accepted this revision.Aug 1 2016, 2:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2016, 2:23 PM

Closed by commit rP5380d877921e: Use long array syntax for compatibility instead of short array syntax (authored by epriestley, committed by epriestley). · Explain WhyAug 1 2016, 5:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

conduit/

HarbormasterQueryBuildsConduitAPIMethod.php

9 lines

Diff 39340

View Options

src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php

Use long array syntax for compatibility instead of short array syntaxClosedPublicActions