Paths

Table of Contentst

Differential D16316

Add PackagesVersion
ClosedPublic
Actions

Authored by epriestley on Jul 21 2016, 7:29 PM.

Details

Reviewers

chad

Maniphest Tasks

T8116: Prototype a package management application

Commits

rPee37eca2e4c2: Add PackagesVersion

Summary

Ref T8116. A version has:

a package (like "Arcanist") which it belongs to;
a name (like "v3.1.5").

The name is immutable and unique, like the package key and publisher key.

Policy stuff:

Versions have the exact same policies as their packages.
You must be able to edit a package to create new versions of it.

This is still entirely uninteresting.

Test Plan

Screen Shot 2016-07-21 at 12.23.13 PM.png (984×1 px, 123 KB)

Diff Detail

Repository

rP Phabricator

Branch

pack3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13163
Build 16847: Run Core Tests
Build 16846: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39236.Jul 21 2016, 7:29 PM

epriestley retitled this revision from to Add PackagesVersion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8116: Prototype a package management application.

chad accepted this revision.Jul 24 2016, 3:34 AM

chad edited edge metadata.

chad added inline comments.

src/applications/packages/controller/PhabricatorPackagesVersionViewController.php
67

This revision is now accepted and ready to land.Jul 24 2016, 3:34 AM

fooishbar mentioned this in T4863: Allow Workboard Cards to be customized for display.Jul 26 2016, 1:35 PM

Use fa-tag.

Closed by commit rPee37eca2e4c2: Add PackagesVersion (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 7:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160721.pack.06.version.sql

10 lines

20160721.pack.07.versionxaction.sql

19 lines

src/

__phutil_library_map__.php

45 lines

applications/

packages/

application/

PhabricatorPackagesApplication.php

8 lines

conduit/

PhabricatorPackagesVersionEditConduitAPIMethod.php

19 lines

PhabricatorPackagesVersionSearchConduitAPIMethod.php

18 lines

controller/

PhabricatorPackagesVersionController.php

4 lines

PhabricatorPackagesVersionEditController.php

12 lines

PhabricatorPackagesVersionListController.php

26 lines

PhabricatorPackagesVersionViewController.php

91 lines

editor/

PhabricatorPackagesVersionEditEngine.php

93 lines

PhabricatorPackagesVersionEditor.php

46 lines

phid/

PhabricatorPackagesVersionPHIDType.php

45 lines

query/

PhabricatorPackagesPackageQuery.php

27 lines

PhabricatorPackagesQuery.php

28 lines

PhabricatorPackagesVersionQuery.php

141 lines

PhabricatorPackagesVersionSearchEngine.php

76 lines

PhabricatorPackagesVersionTransactionQuery.php

10 lines

storage/

PhabricatorPackagesPackage.php

16 lines

	PhabricatorPackagesVersion.php
	PhabricatorPackagesPackage.php

108 lines

PhabricatorPackagesVersionTransaction.php

18 lines

typeahead/

PhabricatorPackagesPackageDatasource.php

35 lines

xaction/

package/

PhabricatorPackagesPackagePublisherTransaction.php

3 lines

version/

PhabricatorPackagesVersionNameTransaction.php

62 lines

PhabricatorPackagesVersionTransactionType.php

4 lines

	version/
	package/

	PhabricatorPackagesVersionPackageTransaction.php
	PhabricatorPackagesPackagePublisherTransaction.php

30 lines

Diff 39287

View Options

resources/sql/autopatches/20160721.pack.06.version.sql

View Options

resources/sql/autopatches/20160721.pack.07.versionxaction.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/packages/application/PhabricatorPackagesApplication.php

View Options

src/applications/packages/conduit/PhabricatorPackagesVersionEditConduitAPIMethod.php

View Options

src/applications/packages/conduit/PhabricatorPackagesVersionSearchConduitAPIMethod.php

View Options

src/applications/packages/controller/PhabricatorPackagesVersionController.php

View Options

src/applications/packages/controller/PhabricatorPackagesVersionEditController.php

View Options

src/applications/packages/controller/PhabricatorPackagesVersionListController.php

View Options

src/applications/packages/controller/PhabricatorPackagesVersionViewController.php

View Options

src/applications/packages/editor/PhabricatorPackagesVersionEditEngine.php

View Options

src/applications/packages/editor/PhabricatorPackagesVersionEditor.php

View Options

src/applications/packages/phid/PhabricatorPackagesVersionPHIDType.php

View Options

src/applications/packages/query/PhabricatorPackagesPackageQuery.php

View Options

src/applications/packages/query/PhabricatorPackagesQuery.php

View Options

src/applications/packages/query/PhabricatorPackagesVersionQuery.php

View Options

src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php

View Options

src/applications/packages/query/PhabricatorPackagesVersionTransactionQuery.php

View Options

src/applications/packages/storage/PhabricatorPackagesPackage.php

View Options

src/applications/packages/storage/PhabricatorPackagesVersion.php

View Options

src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php

View Options

src/applications/packages/typeahead/PhabricatorPackagesPackageDatasource.php

View Options

src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php

View Options

src/applications/packages/xaction/version/PhabricatorPackagesVersionNameTransaction.php

View Options

src/applications/packages/xaction/version/PhabricatorPackagesVersionPackageTransaction.php

View Options

src/applications/packages/xaction/version/PhabricatorPackagesVersionTransactionType.php

Add PackagesVersionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39287

resources/sql/autopatches/20160721.pack.06.version.sql

resources/sql/autopatches/20160721.pack.07.versionxaction.sql

src/__phutil_library_map__.php

src/applications/packages/application/PhabricatorPackagesApplication.php

src/applications/packages/conduit/PhabricatorPackagesVersionEditConduitAPIMethod.php

src/applications/packages/conduit/PhabricatorPackagesVersionSearchConduitAPIMethod.php

src/applications/packages/controller/PhabricatorPackagesVersionController.php

src/applications/packages/controller/PhabricatorPackagesVersionEditController.php

src/applications/packages/controller/PhabricatorPackagesVersionListController.php

src/applications/packages/controller/PhabricatorPackagesVersionViewController.php

src/applications/packages/editor/PhabricatorPackagesVersionEditEngine.php

src/applications/packages/editor/PhabricatorPackagesVersionEditor.php

src/applications/packages/phid/PhabricatorPackagesVersionPHIDType.php

src/applications/packages/query/PhabricatorPackagesPackageQuery.php

src/applications/packages/query/PhabricatorPackagesQuery.php

src/applications/packages/query/PhabricatorPackagesVersionQuery.php

src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php

src/applications/packages/query/PhabricatorPackagesVersionTransactionQuery.php

src/applications/packages/storage/PhabricatorPackagesPackage.php

src/applications/packages/storage/PhabricatorPackagesVersion.php

src/applications/packages/storage/PhabricatorPackagesVersionTransaction.php

src/applications/packages/typeahead/PhabricatorPackagesPackageDatasource.php

src/applications/packages/xaction/package/PhabricatorPackagesPackagePublisherTransaction.php

src/applications/packages/xaction/version/PhabricatorPackagesVersionNameTransaction.php

src/applications/packages/xaction/version/PhabricatorPackagesVersionPackageTransaction.php

src/applications/packages/xaction/version/PhabricatorPackagesVersionTransactionType.php

Add PackagesVersion
ClosedPublic
Actions

Revision Contents
Changeset List