Paths

Table of Contentst

Differential D16312

Allow file comments to be edited
ClosedPublic
Actions

Authored by epriestley on Jul 18 2016, 8:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T10750: Cannot Edit Comment on Files

Commits

rP56bd762dd3ed: Allow file comments to be edited

Summary

Fixes T10750. Files have some outdated cache/key code which prevents recording an edit history on file comments.

Remove this ancient cruft.

(Users must bin/storage adjust after upgrading to this patch to reap the benefits.)

Test Plan

Ran bin/storage adjust.
Edited a comment in Files.

Diff Detail

Repository

rP Phabricator

Branch

file1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13106
Build 16757: Run Core Tests
Build 16756: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39229.Jul 18 2016, 8:16 PM

epriestley retitled this revision from to Allow file comments to be edited.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10750: Cannot Edit Comment on Files.

chad accepted this revision.Jul 18 2016, 10:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 18 2016, 10:45 PM

Closed by commit rP56bd762dd3ed: Allow file comments to be edited (authored by epriestley, committed by epriestley). · Explain WhyJul 18 2016, 11:17 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10750: Cannot Edit Comment on Files.Jul 18 2016, 11:20 PM

• fdxchina added a child revision: D16254: Fix a fatal when viewing a daemon task with an invalid ID.Jul 21 2016, 2:44 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

storage/

PhabricatorFileTransactionComment.php

16 lines

Diff 39229

View Options

src/applications/files/storage/PhabricatorFileTransactionComment.php

Allow file comments to be editedClosedPublicActions