Page MenuHomePhabricator
Differential D16254

Fix a fatal when viewing a daemon task with an invalid ID
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 11:21 PM
Unknown Object (File)
Sun, Jan 26, 8:03 PM
Unknown Object (File)
Sun, Jan 26, 6:44 AM
Unknown Object (File)
Fri, Jan 24, 2:38 PM
Unknown Object (File)
Fri, Jan 24, 2:38 PM
Unknown Object (File)
Fri, Jan 24, 2:38 PM
Unknown Object (File)
Thu, Jan 23, 8:02 AM
Unknown Object (File)
Tue, Jan 21, 12:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11295: Worker queue 404 page fails with invalid `$header`
Commits
rP1c088822b4d2: Fix a fatal when viewing a daemon task with an invalid ID
Summary

Fixes T11295. Prior to this change, the "404 page" for daemon tasks fatals.

This page is special cased a little bit and not a normal 404 page, because it's possible for you to click a valid link and the task to get GC'd by the time you load the page, or similar. It tries to be a little more user-friendly than a bare 404.

Test Plan
  • Visited /daemon/task/1428348920328/ (any invalid ID).
  • Now got a nice "no such task" page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39096.Jul 8 2016, 11:33 AM
epriestley retitled this revision from to Fix a fatal when viewing a daemon task with an invalid ID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11295: Worker queue 404 page fails with invalid `$header`.
chad accepted this revision.Jul 8 2016, 2:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 2:08 PM
Closed by commit rP1c088822b4d2: Fix a fatal when viewing a daemon task with an invalid ID (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2016, 2:08 PM
This revision was automatically updated to reflect the committed changes.
• fdxchina added a parent revision: D16312: Allow file comments to be edited.Jul 21 2016, 2:44 AM

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
controller/
14 lines

Diff 39102

View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

Loading...
Phabricator · Built by Phacility