Page MenuHomePhabricator

Fix a fatal when viewing a daemon task with an invalid ID
ClosedPublic

Authored by epriestley on Jul 8 2016, 11:33 AM.
Tags
None
Referenced Files
F13085035: D16254.diff
Wed, Apr 24, 11:40 PM
Unknown Object (File)
Fri, Apr 12, 2:40 AM
Unknown Object (File)
Thu, Apr 11, 7:57 AM
Unknown Object (File)
Tue, Apr 2, 1:59 PM
Unknown Object (File)
Tue, Apr 2, 3:22 AM
Unknown Object (File)
Mon, Apr 1, 9:16 AM
Unknown Object (File)
Feb 18 2024, 7:28 PM
Unknown Object (File)
Feb 18 2024, 7:28 PM
Subscribers
None

Details

Summary

Fixes T11295. Prior to this change, the "404 page" for daemon tasks fatals.

This page is special cased a little bit and not a normal 404 page, because it's possible for you to click a valid link and the task to get GC'd by the time you load the page, or similar. It tries to be a little more user-friendly than a bare 404.

Test Plan
  • Visited /daemon/task/1428348920328/ (any invalid ID).
  • Now got a nice "no such task" page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a fatal when viewing a daemon task with an invalid ID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 2:08 PM
This revision was automatically updated to reflect the committed changes.