Page MenuHomePhabricator

Fix a fatal when viewing a daemon task with an invalid ID
ClosedPublic

Authored by epriestley on Jul 8 2016, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2026, 6:55 AM
Unknown Object (File)
Feb 3 2026, 1:02 AM
Unknown Object (File)
Jan 9 2026, 3:00 PM
Unknown Object (File)
Dec 9 2025, 4:42 PM
Unknown Object (File)
Nov 29 2025, 5:11 AM
Unknown Object (File)
Nov 26 2025, 9:54 PM
Unknown Object (File)
Nov 26 2025, 8:09 PM
Unknown Object (File)
Nov 5 2025, 11:51 PM
Subscribers
None

Details

Summary

Fixes T11295. Prior to this change, the "404 page" for daemon tasks fatals.

This page is special cased a little bit and not a normal 404 page, because it's possible for you to click a valid link and the task to get GC'd by the time you load the page, or similar. It tries to be a little more user-friendly than a bare 404.

Test Plan
  • Visited /daemon/task/1428348920328/ (any invalid ID).
  • Now got a nice "no such task" page.

Diff Detail

Repository
rP Phabricator
Branch
worker1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12972
Build 16565: Run Core Tests
Build 16564: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a fatal when viewing a daemon task with an invalid ID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 2:08 PM
This revision was automatically updated to reflect the committed changes.