Differential D16226
Implement a "pro" EditEngine for dashboard panels Authored by epriestley on Jul 3 2016, 9:47 PM. Tags None Referenced Files
Subscribers None
Details Ref T10855. This can't replace the old edit flow yet, but get the basics in place. (This is actually much closer to just being able to swap than I anticipated since CustomFields sort of just work, but the exiting flow has some "clone existing panel" / "place directly on dashboard" stuff that this doesn't yet.) Created and edited a panel by manually using the "editpro" flow.
Diff Detail
Event TimelineComment Actions Yes, but they seem possibly useful to me -- are you only concerned about T11161? For panels other than Query panels (text, tabs, actions, phriction, etc. -- all other future panels?) it seems like this probably isn't confusing. Maybe the root issue is just "query panels are weird right now"? That said, there's also no current use for it, so we can nuke it until one arises and then that use case can fight confusion on query panels, I guess. Comment Actions Yeah I've never used it, and I can see Projects useful maybe for Dashboards, but not Panels so much. Both seem like a mess. to find anything useful. Comment Actions
Comment Actions Once we swap over fully adding or removing support is just a matter of adding or removing implements PhabricatorProjectInterface, so starting simpler seems reasonable to me. |