Page MenuHomePhabricator

Implement a "pro" EditEngine for dashboard panels
ClosedPublic

Authored by epriestley on Jul 3 2016, 9:47 PM.
Tags
None
Referenced Files
F13307341: D16226.diff
Sun, Jun 9, 4:55 PM
F13287161: D16226.id39030.diff
Tue, Jun 4, 8:23 AM
F13268697: D16226.diff
Wed, May 29, 5:18 AM
F13257496: D16226.id39029.diff
Sun, May 26, 1:52 AM
F13254275: D16226.diff
Sat, May 25, 3:17 AM
F13245809: D16226.id39030.diff
Thu, May 23, 6:15 AM
F13241619: D16226.id39029.diff
Wed, May 22, 10:52 PM
F13237938: D16226.id.diff
Tue, May 21, 4:09 PM
Subscribers
None

Details

Summary

Ref T10855. This can't replace the old edit flow yet, but get the basics in place.

(This is actually much closer to just being able to swap than I anticipated since CustomFields sort of just work, but the exiting flow has some "clone existing panel" / "place directly on dashboard" stuff that this doesn't yet.)

Test Plan

Created and edited a panel by manually using the "editpro" flow.

Diff Detail

Repository
rP Phabricator
Branch
panel1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12913
Build 16473: Run Core Tests
Build 16472: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Implement a "pro" EditEngine for dashboard panels.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Can we get rid of projects on panels, too?

epriestley edited edge metadata.
  • Also just sketch in dashboard.panel.edit here.

Yes, but they seem possibly useful to me -- are you only concerned about T11161?

For panels other than Query panels (text, tabs, actions, phriction, etc. -- all other future panels?) it seems like this probably isn't confusing. Maybe the root issue is just "query panels are weird right now"?

That said, there's also no current use for it, so we can nuke it until one arises and then that use case can fight confusion on query panels, I guess.

Yeah I've never used it, and I can see Projects useful maybe for Dashboards, but not Panels so much. Both seem like a mess. to find anything useful.

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 3 2016, 10:06 PM
epriestley edited edge metadata.
  • Remove ProjectInterface to get rid of "Tags" on EditProController.
  • Remove all the tag logic from EditController manually.

Once we swap over fully adding or removing support is just a matter of adding or removing implements PhabricatorProjectInterface, so starting simpler seems reasonable to me.

This revision was automatically updated to reflect the committed changes.