Convert "Diff Details" tabs to PHUITabGroup
ClosedPublic
Actions

Authored by epriestley on Jun 30 2016, 11:11 PM.

Details

Reviewers

Maniphest Tasks

T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential

Commits

rP5a4ecc7a9c5b: Convert "Diff Details" tabs to PHUITabGroup

Summary

Ref T10628. Switch this to be nicer and more modern.

When there's only one tab, add an option to hide it.

Test Plan

Viewed normal revisions (no tabs).
Viewed X vs Y revisions (two tabs, rightmost tab selected by default).

Diff Detail

Repository

rP Phabricator

Branch

tabs2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12859
Build 16392: Run Core Tests
Build 16391: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38982.Jun 30 2016, 11:11 PM

epriestley retitled this revision from to Convert "Diff Details" tabs to PHUITabGroup.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

chad accepted this revision.Jun 30 2016, 11:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2016, 11:12 PM

Closed by commit rP5a4ecc7a9c5b: Convert "Diff Details" tabs to PHUITabGroup (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2016, 1:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

26 lines

view/

phui/

PHUITabGroupView.php

37 lines

Diff 38982

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php