Differential D16167

Don't show client-side setup prompts until user accounts activate
ClosedPublic
Actions

Authored by epriestley on Jun 22 2016, 6:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T11198: browser timezone popup shows for disabled accounts

Commits

rP60c55387ab3b: Don't show client-side setup prompts until user accounts activate

Summary

Fixes T11198. These are confusing or premature if you aren't an activated user: disabled or unapproved accounts won't be able to act on them.

Test Plan

Changed timezone, went through flow to correct it

Diff Detail

Repository

rP Phabricator

Branch

tz1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12772
Build 16257: Run Core Tests
Build 16256: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38891.Jun 22 2016, 6:45 PM

epriestley retitled this revision from to Don't show client-side setup prompts until user accounts activate.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11198: browser timezone popup shows for disabled accounts.

epriestley mentioned this in T11198: browser timezone popup shows for disabled accounts.Jun 22 2016, 6:47 PM

chad accepted this revision.Jun 22 2016, 6:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2016, 6:49 PM

Closed by commit rP60c55387ab3b: Don't show client-side setup prompts until user accounts activate (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2016, 6:54 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D16170: Allow device-to-device SSH to establish SSH sessions.Jun 22 2016, 8:40 PM

epriestley mentioned this in rP72588d2eaaa0: Allow device-to-device SSH to establish SSH sessions.Jun 22 2016, 8:46 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

4 lines

view/

page/

PhabricatorStandardPageView.php

2 lines

Diff 38891

View Options

src/applications/people/storage/PhabricatorUser.php