Page MenuHomePhabricator

Render dropdown metadata earlier
ClosedPublic

Authored by epriestley on Jun 20 2016, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:39 AM
Unknown Object (File)
Sun, Apr 21, 11:04 PM
Unknown Object (File)
Fri, Apr 19, 4:56 PM
Unknown Object (File)
Fri, Apr 12, 9:13 AM
Unknown Object (File)
Mar 28 2024, 2:10 PM
Unknown Object (File)
Feb 22 2024, 12:04 PM
Unknown Object (File)
Feb 14 2024, 1:49 PM
Unknown Object (File)
Feb 14 2024, 1:45 PM
Subscribers
None

Details

Summary

Ref T11179. One issue I'm getting with trying to turn actions into dropdowns is that we currently render this menu very late, which can cause us to try to add more metadata after we start resolving metadata. This won't work right now (and making it work seems unreasonably complicated), so stop doing it and fatal if something tries.

(This might make some things fatal but should be safe -- anything that fatals should have been broken already.)

Test Plan

Browsed around looking for fatals, didn't see any.

(This primarily avoids a broken state / fatal in a future diff.)

Diff Detail

Repository
rP Phabricator
Branch
dropdown1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12737
Build 16201: Run Core Tests
Build 16200: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Render dropdown metadata earlier.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 6:58 PM
This revision was automatically updated to reflect the committed changes.