Remove all uses of PhutilGitURI in Phabricator
ClosedPublic
Actions

Authored by epriestley on Jun 13 2016, 1:14 PM.

Details

Reviewers

chad

Maniphest Tasks

T11137: Unable to update Git repositories with latest stable

Commits

rPb26ecb189e48: (stable) Remove all uses of PhutilGitURI in Phabricator
rPbba53205de4a: Remove all uses of PhutilGitURI in Phabricator

Summary

Ref T11137. This class is removed in D16099. Depends on D16099.

PhutilURI now attempts to "just work" with Git-style URIs, so at least in theory we can just delete all of this code and pretend it does not exist.

(I've left "Display URI" and "Effective URI" as distinct, at least for now, because I think the distinction may be relevant in the future even though it isn't right now, and to keep this diff small, although I may go remove one after I think about this for a bit.)

Test Plan

Created a new Git repository with a Git URI.
Pulled/updated it, which now works correctly and should resolve the original issue in T11137.
Verified that daemons now align the origin to a Git-style URI with a relative path, which should resolve the original issue in T11004.
Grepped for PhutilGitURI.
Also grepped in arcanist/, but found no matches, so no patch for that.
Checked display/conduit URIs.

Diff Detail

Repository

rP Phabricator

Branch

gituri2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12611
Build 16011: Run Core Tests
Build 16010: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	PhabricatorRepositoryTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PhabricatorRepositoryTestCase.php:26): Protocol for 'git@example.com:path'. Expected: 'ssh' Actual: ''
	0 ms	PhabricatorRepositoryURINormalizerTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PhabricatorRepositoryURINormalizerTestCase.php:30): Normalized Git path for "git@domain.com:path.git". Expected: 'path' Actual: 'git@domain.com:path'
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (2 Failed · 331 Passed)