Page MenuHomePhabricator

Remove all uses of PhutilGitURI in Phabricator
ClosedPublic

Authored by epriestley on Jun 13 2016, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 2:05 PM
Unknown Object (File)
Fri, Dec 13, 6:41 AM
Unknown Object (File)
Mon, Dec 9, 11:36 AM
Unknown Object (File)
Fri, Dec 6, 1:28 AM
Unknown Object (File)
Mon, Nov 25, 10:03 PM
Unknown Object (File)
Thu, Nov 21, 10:55 PM
Unknown Object (File)
Thu, Nov 21, 5:43 PM
Unknown Object (File)
Thu, Nov 21, 12:44 AM
Subscribers
None

Details

Summary

Ref T11137. This class is removed in D16099. Depends on D16099.

PhutilURI now attempts to "just work" with Git-style URIs, so at least in theory we can just delete all of this code and pretend it does not exist.

(I've left "Display URI" and "Effective URI" as distinct, at least for now, because I think the distinction may be relevant in the future even though it isn't right now, and to keep this diff small, although I may go remove one after I think about this for a bit.)

Test Plan
  • Created a new Git repository with a Git URI.
  • Pulled/updated it, which now works correctly and should resolve the original issue in T11137.
  • Verified that daemons now align the origin to a Git-style URI with a relative path, which should resolve the original issue in T11004.
  • Grepped for PhutilGitURI.
  • Also grepped in arcanist/, but found no matches, so no patch for that.
  • Checked display/conduit URIs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove all uses of PhutilGitURI in Phabricator.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Those test failures are expected until D16099 lands.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2016, 1:48 PM
This revision was automatically updated to reflect the committed changes.