Page MenuHomePhabricator

Use HTTPEngineExtension proxy for `git` HTTP operations
ClosedPublic

Authored by epriestley on Jun 9 2016, 6:50 PM.
Tags
None
Referenced Files
F13203793: D16092.diff
Wed, May 15, 12:07 AM
F13189306: D16092.diff
Sat, May 11, 5:51 AM
Unknown Object (File)
Wed, Apr 24, 11:21 PM
Unknown Object (File)
Mon, Apr 22, 2:44 AM
Unknown Object (File)
Sat, Apr 20, 3:24 PM
Unknown Object (File)
Fri, Apr 19, 4:53 PM
Unknown Object (File)
Apr 12 2024, 8:23 AM
Unknown Object (File)
Apr 12 2024, 7:48 AM
Subscribers
None

Details

Summary

Ref T10227. When we perform git http operations (fetch, mirror) check if we should use a proxy; if we should, set http_proxy or https_proxy in the environment to make git have curl use it.

Test Plan
  • Configured a proxy extension to run stuff through a local instance of Charles.
  • Ran repository pull and repository mirror.
  • Saw git HTTP requests route through the proxy.

Diff Detail

Repository
rP Phabricator
Branch
http3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12585
Build 15973: Run Core Tests
Build 15972: arc lint + arc unit