Page MenuHomePhabricator

Use HTTPEngineExtension proxy for `git` HTTP operations
ClosedPublic

Authored by epriestley on Jun 9 2016, 6:50 PM.
Tags
None
Referenced Files
F15455457: D16092.id.diff
Sun, Mar 30, 12:33 AM
F15449608: D16092.diff
Fri, Mar 28, 11:15 AM
F15422949: D16092.id38717.diff
Sat, Mar 22, 11:36 AM
F15419518: D16092.id38714.diff
Fri, Mar 21, 6:43 AM
F15381931: D16092.diff
Fri, Mar 14, 9:57 AM
F15371228: D16092.id38717.diff
Wed, Mar 12, 11:44 AM
F15293223: D16092.diff
Wed, Mar 5, 3:37 AM
F15282514: D16092.diff
Tue, Mar 4, 12:17 AM
Subscribers
None

Details

Summary

Ref T10227. When we perform git http operations (fetch, mirror) check if we should use a proxy; if we should, set http_proxy or https_proxy in the environment to make git have curl use it.

Test Plan
  • Configured a proxy extension to run stuff through a local instance of Charles.
  • Ran repository pull and repository mirror.
  • Saw git HTTP requests route through the proxy.

Diff Detail

Repository
rP Phabricator
Branch
http3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12585
Build 15973: Run Core Tests
Build 15972: arc lint + arc unit