Page MenuHomePhabricator

Use prose diffs in Phriction
ClosedPublic

Authored by epriestley on Jun 6 2016, 9:01 PM.
Tags
None
Referenced Files
F18776961: D16062.id38650.diff
Sat, Oct 11, 12:19 AM
F18773369: D16062.id.diff
Thu, Oct 9, 9:21 AM
F18764603: D16062.diff
Tue, Oct 7, 6:50 AM
F18761636: D16062.diff
Mon, Oct 6, 3:28 PM
F18733365: D16062.id.diff
Tue, Sep 30, 10:33 PM
F18704387: D16062.diff
Sun, Sep 28, 7:24 AM
F18656643: D16062.diff
Mon, Sep 22, 11:03 PM
F18643988: D16062.id38650.diff
Fri, Sep 19, 3:57 AM
Subscribers
Tokens
"Love" token, awarded by avivey.

Details

Summary

Ref T3353. This improves whitespace display of prose diffs and uses them in Phriction.

Test Plan

Screen Shot 2016-06-06 at 1.58.36 PM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use prose diffs in Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

This is awesome, but is it really on the way to T3353? Wouldn't we need to replace it with a view that supports inline-comments?

This revision is now accepted and ready to land.Jun 6 2016, 9:14 PM

I'll clarify T3353 shortly -- I'm not planning to, e.g., implement Google Docs.

This revision was automatically updated to reflect the committed changes.