Page MenuHomePhabricator
Differential D16062

Use prose diffs in Phriction
ClosedPublic
Actions

Authored by epriestley on Jun 6 2016, 9:01 PM.
Tags
None
Referenced Files
F13052643: D16062.id38650.diff
Fri, Apr 19, 10:19 AM
F13051873: D16062.id.diff
Fri, Apr 19, 5:18 AM
F13049910: D16062.diff
Fri, Apr 19, 2:31 AM
Unknown Object (File)
Wed, Apr 17, 3:11 PM
Unknown Object (File)
Wed, Apr 3, 10:41 PM
Unknown Object (File)
Sun, Mar 31, 6:45 AM
Unknown Object (File)
Thu, Mar 28, 12:44 PM
Unknown Object (File)
Thu, Mar 21, 10:31 PM
View All Files
Subscribers
avivey
Tokens
"Love" token, awarded by avivey.

Details

Reviewers
avivey
chad
Maniphest Tasks
T3353: Make Phriction Document changes reviewable
Commits
rP02877c600a75: Use prose diffs in Phriction
Summary

Ref T3353. This improves whitespace display of prose diffs and uses them in Phriction.

Test Plan

Screen Shot 2016-06-06 at 1.58.36 PM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Branch
prose4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12519
Build 15876: Run Core Tests
Build 15875: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38648.Jun 6 2016, 9:01 PM
epriestley retitled this revision from to Use prose diffs in Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T3353: Make Phriction Document changes reviewable.
Herald edited edge metadata. · View Herald TranscriptJun 6 2016, 9:01 PM
avivey awarded a token.Jun 6 2016, 9:11 PM
avivey accepted this revision.Jun 6 2016, 9:14 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

This is awesome, but is it really on the way to T3353? Wouldn't we need to replace it with a view that supports inline-comments?

This revision is now accepted and ready to land.Jun 6 2016, 9:14 PM
epriestley added a comment.Jun 6 2016, 9:33 PM

I'll clarify T3353 shortly -- I'm not planning to, e.g., implement Google Docs.

Closed by commit rP02877c600a75: Use prose diffs in Phriction (authored by epriestley, committed by epriestley). · Explain WhyJun 6 2016, 9:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
phriction/
controller/
65 lines
webroot/
rsrc/
css/
application/
differential/
8 lines

Diff 38648

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility