Page MenuHomePhabricator

Use prose diffs in Phriction
ClosedPublic

Authored by epriestley on Jun 6 2016, 9:01 PM.
Tags
None
Referenced Files
F11515726: D16062.diff
Tue, Jan 31, 3:20 AM
Unknown Object (File)
Sat, Jan 28, 4:28 AM
Unknown Object (File)
Dec 24 2022, 12:08 AM
Unknown Object (File)
Dec 24 2022, 12:01 AM
Unknown Object (File)
Dec 23 2022, 11:37 PM
Unknown Object (File)
Dec 21 2022, 10:12 PM
Unknown Object (File)
Dec 19 2022, 6:05 PM
Unknown Object (File)
Dec 7 2022, 2:11 AM
Subscribers
Tokens
"Love" token, awarded by avivey.

Details

Summary

Ref T3353. This improves whitespace display of prose diffs and uses them in Phriction.

Test Plan

Screen Shot 2016-06-06 at 1.58.36 PM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Branch
prose4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12519
Build 15876: Run Core Tests
Build 15875: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use prose diffs in Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

This is awesome, but is it really on the way to T3353? Wouldn't we need to replace it with a view that supports inline-comments?

This revision is now accepted and ready to land.Jun 6 2016, 9:14 PM

I'll clarify T3353 shortly -- I'm not planning to, e.g., implement Google Docs.

This revision was automatically updated to reflect the committed changes.