Paths

Table of Contentst

Differential D16059

Don't specify size 0 for deleted files
ClosedPublic
Actions

Authored by avivey on Jun 6 2016, 7:57 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCca3324094259: Don't specify size 0 for deleted files

Summary

See D15828 - arc is reporting file size as 0 for unexisting files - make it stop.

Test Plan

arc diff with empty, deleted, added files - see size reported as null when appropriate.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12511
Build 15865: Run Core Tests
Build 15864: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 38640.Jun 6 2016, 7:57 PM

avivey retitled this revision from to Don't specify size 0 for deleted files.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 6 2016, 7:57 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 6 2016, 8:03 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 6 2016, 8:03 PM

awwyiss

Closed by commit rARCca3324094259: Don't specify size 0 for deleted files (authored by avivey, committed by avivey). · Explain WhyJun 6 2016, 8:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

9 lines

Diff 38640

View Options

src/workflow/ArcanistDiffWorkflow.php

Don't specify size 0 for deleted filesClosedPublicActions