Page MenuHomePhabricator

Improve some settings-related performance
ClosedPublic

Authored by epriestley on Jun 5 2016, 2:49 PM.
Tags
None
Referenced Files
F19524396: D16046.id38600.diff
Sun, Jan 18, 12:42 AM
F19518164: D16046.id.diff
Thu, Jan 15, 6:25 PM
F19515181: D16046.diff
Wed, Jan 14, 8:54 AM
F19082603: D16046.diff
Dec 2 2025, 11:55 AM
F18991251: D16046.id38613.diff
Nov 18 2025, 9:40 PM
F18991250: D16046.id.diff
Nov 18 2025, 9:40 PM
F18821777: D16046.id38600.diff
Oct 23 2025, 1:45 AM
F18821726: D16046.diff
Oct 23 2025, 1:29 AM
Subscribers
None

Details

Summary

Ref T4103. Two small improvements:

  • Don't work as hard to validate translations. We just need to know if a translation exists, we don't need to count how many strings it has and build the entire menu.
  • Allow getUserSetting() to work on any setting without doing all the application/visibility checks. It's OK for code to look at, say, your "Conpherence Notifications" setting even if that application is not installed for you.
Test Plan

Used XHProf and saw 404 page drop from ~60ms to ~40ms locally.

Diff Detail

Repository
rP Phabricator
Branch
setting35
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12471
Build 15808: Run Core Tests
Build 15807: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve some settings-related performance.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 5:31 PM
This revision was automatically updated to reflect the committed changes.