HomePhabricator

Fully modularize the "Quick Actions" menu

Description

Fully modularize the "Quick Actions" menu

Summary:
Ref T10077. Currently, we issue 6+ queries on every page to build this menu, since the menu is built application-by-application.

Build the menu with dedicated modules instead so a single "EditEngine" module can provide all of them with one query.

I'd like to reduce this to 0 queries but I'm not totally sure what we want to do with this menu.

This change removes these items, because EditEngine can not currently provide them:

  • Calendar: Eventually via EditEngine eventually.
  • Conpherence: Probably via EditEngine, doesn't seem too important.
  • People: Maybe via EditEngine, doesn't seem too important? "Welcome" is likely better?
  • Pholio: Eventually via EditEngine.

It adds a bunch of other items as a side effect:

Screen Shot 2016-06-05 at 7.26.04 AM.png (417×220 px, 30 KB)

This reduces the queries issued on every page by ~5.

This also makes quick create actions visible while logged out (see T7073).

Test Plan:

  • Viewed menu while logged in.
  • Viewed menu while logged out.
  • Viewed standalone version of menu.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10077

Differential Revision: https://secure.phabricator.com/D16045

Details