Page MenuHomePhabricator

Improve some settings-related performance
ClosedPublic

Authored by epriestley on Jun 5 2016, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 7:49 AM
Unknown Object (File)
Sat, Nov 23, 11:27 AM
Unknown Object (File)
Tue, Nov 19, 3:57 PM
Unknown Object (File)
Nov 15 2024, 11:12 AM
Unknown Object (File)
Nov 11 2024, 2:10 AM
Unknown Object (File)
Nov 10 2024, 9:56 PM
Unknown Object (File)
Nov 7 2024, 3:24 AM
Unknown Object (File)
Nov 2 2024, 5:09 PM
Subscribers
None

Details

Summary

Ref T4103. Two small improvements:

  • Don't work as hard to validate translations. We just need to know if a translation exists, we don't need to count how many strings it has and build the entire menu.
  • Allow getUserSetting() to work on any setting without doing all the application/visibility checks. It's OK for code to look at, say, your "Conpherence Notifications" setting even if that application is not installed for you.
Test Plan

Used XHProf and saw 404 page drop from ~60ms to ~40ms locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve some settings-related performance.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 5:31 PM
This revision was automatically updated to reflect the committed changes.