Page MenuHomePhabricator
Differential D15957

Add transparency to Pholio Edit thumbs
ClosedPublic
Actions

Authored by chad on May 20 2016, 8:38 PM.
Tags
None
Referenced Files
F14858830: D15957.id38420.diff
Thu, Feb 6, 6:10 AM
Unknown Object (File)
Thu, Jan 30, 3:31 PM
Unknown Object (File)
Wed, Jan 29, 7:22 PM
Unknown Object (File)
Wed, Jan 29, 4:56 PM
Unknown Object (File)
Wed, Jan 29, 10:32 AM
Unknown Object (File)
Wed, Jan 29, 7:20 AM
Unknown Object (File)
Tue, Jan 28, 6:00 PM
Unknown Object (File)
Thu, Jan 23, 3:27 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard
Commits
rP77d543ba4463: (stable) Promote 2016 Week 21
rP804a5db41a9a: Add transparency to Pholio Edit thumbs
Summary

Makes the background transparent for uploaded thumbs. This page in general needs lots of work, but here's the minimum. Fixes T10986

Test Plan

Edit a Mock with a transparent jeff.

Diff Detail

Repository
rP Phabricator
Branch
pholio-edit (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12289
Build 15535: Run Core Tests
Build 15534: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38419.May 20 2016, 8:38 PM
chad retitled this revision from to Add transparency to Pholio Edit thumbs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.
Herald added a subscriber: Korvin. · View Herald TranscriptMay 20 2016, 8:38 PM
epriestley accepted this revision.May 20 2016, 8:39 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2016, 8:39 PM
epriestley added a comment.May 20 2016, 8:39 PM

transparent jeff

haha

Closed by commit rP804a5db41a9a: Add transparency to Pholio Edit thumbs (authored by chad, committed by chad). · Explain WhyMay 20 2016, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
pholio/
view/
11 lines
webroot/
rsrc/
css/
application/
pholio/
18 lines

Diff 38419

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/view/PholioUploadedImageView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio-edit.css

Loading...
Phabricator · Built by Phacility