Fix an issue with TextAreaEditField affecting Paste
ClosedPublic
Actions

Authored by epriestley on May 11 2016, 10:34 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T10930: Exception in editengine for Paste
T10952: Cannot edit pastes, if you want to keep the content

Commits

rP54409e771649: Fix an issue with TextAreaEditField affecting Paste

Summary

Fixes T10952. Fixes T10930. I didn't implement this method correctly when I expanded this field for repositories.

Test Plan

Edited a paste without warnings.

Diff Detail

Repository

rP Phabricator

Branch

pasteedit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12154
Build 15334: Run Core Tests
Build 15333: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38280.May 11 2016, 10:34 PM

epriestley retitled this revision from to Fix an issue with TextAreaEditField affecting Paste.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added tasks: T10952: Cannot edit pastes, if you want to keep the content, T10930: Exception in editengine for Paste.

chad accepted this revision.May 11 2016, 10:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 11 2016, 10:35 PM

Closed by commit rP54409e771649: Fix an issue with TextAreaEditField affecting Paste (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 10:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editfield/

PhabricatorTextAreaEditField.php

6 lines

Diff 38280

View Options

src/applications/transactions/editfield/PhabricatorTextAreaEditField.php

Fix an issue with TextAreaEditField affecting PasteClosedPublicActions