Paths

Table of Contentst

Differential D15882

Allow "+" to remain unescaped by csprintf('%R', ...)
ClosedPublic
Actions

Authored by epriestley on May 11 2016, 12:01 AM.

Details

Reviewers

chad

Maniphest Tasks

T10923: Diffusion API/URI Errata

Commits

rPHUa51a8b98305e: (stable) Promote 2016 Week 20
rPHUb25e0477b280: Allow "+" to remain unescaped by csprintf('%R', ...)

Summary

Ref T10923. Currently, when we %R ("readable") escape SVN SSH URIs (svn+ssh://...), they get quoted because they contain a +.

However, they don't need to be quoted, since + is not a special character in the shell.

Test Plan

Added and ran test cases.
Viewed SVN in Diffusion, saw unquoted checkout URI.

Diff Detail

Repository

rPHU libphutil

Branch

readable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12125
Build 15290: Run Core Tests
Build 15289: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38250.May 11 2016, 12:01 AM

epriestley retitled this revision from to Allow "+" to remain unescaped by csprintf('%R', ...).

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10923: Diffusion API/URI Errata.

chad accepted this revision.May 11 2016, 2:57 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 11 2016, 2:57 AM

Closed by commit rPHUb25e0477b280: Allow "+" to remain unescaped by csprintf('%R', ...) (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 1:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

__tests__/

PhutilCsprintfTestCase.php

31 lines

csprintf.php

2 lines

Diff 38250

View Options

src/xsprintf/tests/PhutilCsprintfTestCase.php

View Options

Allow "+" to remain unescaped by csprintf('%R', ...)ClosedPublicActions