Paths

Table of Contentst

Differential D15876

Index all repository URIs, not just the "primary" repository URI
ClosedPublic
Actions

Authored by epriestley on May 10 2016, 1:27 PM.

Tags

None

Referenced Files

	F13112051: D15876.diff
	Sun, Apr 28, 1:20 PM

	Unknown Object (File)
	Thu, Apr 25, 12:11 AM

	Unknown Object (File)
	Thu, Apr 11, 2:03 PM

	Unknown Object (File)
	Thu, Apr 11, 8:27 AM

	Unknown Object (File)
	Mon, Apr 8, 11:14 PM

	Unknown Object (File)
	Sat, Apr 6, 3:03 PM

	Unknown Object (File)
	Mar 29 2024, 10:29 AM

	Unknown Object (File)
	Feb 15 2024, 8:54 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10923: Diffusion API/URI Errata

Commits

rP576b73dc5375: Index all repository URIs, not just the "primary" repository URI

Summary

Ref T10923. When regenerating the URI index for a repository, index every URI.

Also, make the index slightly stricter (domain + path instead of just path). Excluding the domain made more sense when we were generating only first-party URIs.
Make the index smarter about /diffusion/123/ URIs.
Show normalized URIs in diffusion.repository.search results.

Test Plan

Ran migration.
Verified sensible-looking results in database.
Searched for a repository URI by first-party clone URI.
Searched for a repository URI by mirror URI.
Used diffusion.repository.search to get information about repository URIs.

Diff Detail

Repository

Branch

dxdoc10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12117
Build 15276: Run Core Tests
Build 15275: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38242.May 10 2016, 1:27 PM

epriestley retitled this revision from to Index all repository URIs, not just the "primary" repository URI.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10923: Diffusion API/URI Errata.

chad accepted this revision.May 10 2016, 8:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 10 2016, 8:54 PM

epriestley mentioned this in T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist.May 11 2016, 1:35 PM

Closed by commit rP576b73dc5375: Index all repository URIs, not just the "primary" repository URI (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 1:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160112.repo.02.uri.index.php

7 lines

20160510.repo.01.uriindex.php

10 lines

src/

applications/

repository/

data/

PhabricatorRepositoryURINormalizer.php

35 lines

query/

PhabricatorRepositoryQuery.php

24 lines

PhabricatorRepositorySearchEngine.php

9 lines

storage/

PhabricatorRepository.php

35 lines

PhabricatorRepositoryURI.php

21 lines

Diff 38242

resources/sql/autopatches/20160112.repo.02.uri.index.php

Loading...

resources/sql/autopatches/20160510.repo.01.uriindex.php

Loading...

src/applications/repository/data/PhabricatorRepositoryURINormalizer.php

Loading...

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...