Page MenuHomePhabricator

Update redirect/cancel URIs for repository dialogs
ClosedPublic

Authored by epriestley on May 9 2016, 2:07 PM.
Tags
None
Referenced Files
F13167808: D15867.diff
Tue, May 7, 7:23 AM
Unknown Object (File)
Sun, May 5, 9:47 AM
Unknown Object (File)
Fri, May 3, 6:07 AM
Unknown Object (File)
Thu, Apr 25, 1:01 AM
Unknown Object (File)
Thu, Apr 11, 8:45 AM
Unknown Object (File)
Mon, Apr 8, 11:00 AM
Unknown Object (File)
Apr 3 2024, 2:22 PM
Unknown Object (File)
Mar 16 2024, 10:16 AM
Subscribers
None

Details

Summary

Ref T10923. Some of the dialogs ("Deactivate Repository", "Test Automation", etc.) had cancel or redirect URIs which I missed originally.

Go through them and make sure they all point to the right places.

Also removed one unused controller which I missed the first time around.

Test Plan
  • Opened all these dialogs in a new tab with Command-Click.
  • Clicked every "cancel" and "submit" button on all of these dialogs.
  • Got consistently sent to the place I came from.

Diff Detail

Repository
rP Phabricator
Branch
dxdoc2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12096
Build 15243: Run Core Tests
Build 15242: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Update redirect/cancel URIs for repository dialogs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 9 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.