Page MenuHomePhabricator

Update redirect/cancel URIs for repository dialogs
ClosedPublic

Authored by epriestley on May 9 2016, 2:07 PM.
Tags
None
Referenced Files
F14056129: D15867.diff
Sat, Nov 16, 6:25 PM
F13985028: D15867.id38234.diff
Oct 20 2024, 5:37 PM
Unknown Object (File)
Sep 23 2024, 7:08 PM
Unknown Object (File)
Sep 23 2024, 5:40 PM
Unknown Object (File)
Sep 12 2024, 8:29 AM
Unknown Object (File)
Sep 5 2024, 8:12 PM
Unknown Object (File)
Sep 3 2024, 8:54 AM
Unknown Object (File)
Aug 26 2024, 8:09 PM
Subscribers
None

Details

Summary

Ref T10923. Some of the dialogs ("Deactivate Repository", "Test Automation", etc.) had cancel or redirect URIs which I missed originally.

Go through them and make sure they all point to the right places.

Also removed one unused controller which I missed the first time around.

Test Plan
  • Opened all these dialogs in a new tab with Command-Click.
  • Clicked every "cancel" and "submit" button on all of these dialogs.
  • Got consistently sent to the place I came from.

Diff Detail

Repository
rP Phabricator
Branch
dxdoc2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12096
Build 15243: Run Core Tests
Build 15242: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Update redirect/cancel URIs for repository dialogs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 9 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.