Paths

Table of Contentst

Differential D15860

Add coalesce and spaceship operators to xhpast
ClosedPublic
Actions

Authored by richardvanvelzen on May 6 2016, 10:05 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast

Summary

$value ?? $other is roughtly translates to isset($value) ? $value : $other
$a <=> $b translates to ($a < $b) ? -1 : (($a > $b) ? 1 : 0).

Because these new tokens appear in-between other tokens, a lot of token values were updated. All test cases have been updated to have the correct token values.

Test Plan

Fully rebuild xhpast, run all parser tests.

Diff Detail

Repository

rPHU libphutil

Branch

xhpast-coalesce

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12078
Build 15217: arc lint + arc unit

Event Timeline

richardvanvelzen updated this revision to Diff 38202.May 6 2016, 10:05 AM

richardvanvelzen retitled this revision from to Add coalesce and spaceship operators to xhpast.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2016, 10:05 AM

Herald added a subscriber: Korvin. · View Herald Transcript

On a sidenote, arc unit --everything in arcanist seems totally okay with these changes as well.

src/parser/xhpast/parser_tokens.php
5	I copied / adapted this list from `YYTOKENTYPE` in `parser.yacc.cpp`. It seemed a bit out-of date.

Remove useless %token declaration for T_COALESCE

This is starting to bite us now - especially the coalesce construct is so useful that people started using it, taking lint syntax errors for granted.

If there's anything in particular I can change here to make reviewing it more bearable please let me know.

I vaguely imagined fixing the unit test format to be human-readable while you were away for the weekend, but obviously did not.

This revision is now accepted and ready to land.May 18 2016, 4:58 PM

Closed by commit rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyMay 19 2016, 9:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

base-pass.php.test

4 lines

call-time-pass-by-ref.php.test

10 lines

namespace.php.test

70 lines

	operator-coalesce.php.test
	php-only-finally.test

75 lines

operator-spaceship-nonassoc.php.test

4 lines

	operator-spaceship.php.test
	php-empty-heredoc.php.test

32 lines

php-access-on-instanciation.test

100 lines

php-array-dereference-2.test

24 lines

php-array-dereference-3.test

24 lines

php-array-dereference.test

78 lines

php-binary-literal.php.test

6 lines

php-callable-typehint.php.test

20 lines

php-comments.php.test

18 lines

php-empty-heredoc.php.test

14 lines

php-finally.php.test

30 lines

php-literal-index.php.test

16 lines

php-literals.php.test

52 lines

php-only-finally.test

18 lines

php-short-array.php.test

6 lines

1880 lines

38 lines

186 lines

80 lines

218 lines

70 lines

100 lines

bin/

PhutilXHPASTBinary.php

2 lines

parser_tokens.php

276 lines

support/

xhpast/

14 lines

236 lines

5580 lines

2 lines

2 lines

41938 lines

2 lines

Diff 38203

View Options

src/parser/xhpast/tests/data/base-pass.php.test

View Options

src/parser/xhpast/tests/data/call-time-pass-by-ref.php.test

View Options

src/parser/xhpast/tests/data/namespace.php.test

View Options

src/parser/xhpast/tests/data/operator-coalesce.php.test

View Options

src/parser/xhpast/tests/data/operator-spaceship-nonassoc.php.test

View Options

src/parser/xhpast/tests/data/operator-spaceship.php.test

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-2.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-3.test

View Options

src/parser/xhpast/tests/data/php-array-dereference.test

View Options

src/parser/xhpast/tests/data/php-binary-literal.php.test

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-comments.php.test

View Options

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

View Options

src/parser/xhpast/tests/data/php-finally.php.test

View Options

src/parser/xhpast/tests/data/php-literal-index.php.test

View Options

src/parser/xhpast/tests/data/php-literals.php.test

View Options

src/parser/xhpast/tests/data/php-only-finally.test

View Options

src/parser/xhpast/tests/data/php-short-array.php.test

View Options

src/parser/xhpast/tests/data/php-syntax.php.test

View Options

src/parser/xhpast/tests/data/php-tags.php.test

View Options

src/parser/xhpast/tests/data/php-traits.php.test

View Options

src/parser/xhpast/tests/data/php-yield.php.test

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/tests/data/use.php.test

View Options

src/parser/xhpast/tests/data/variadic.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

src/parser/xhpast/parser_tokens.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.hpp

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/scanner.l

View Options

support/xhpast/scanner.lex.hpp

View Options

support/xhpast/scanner.lex.cpp

View Options

Add coalesce and spaceship operators to xhpastClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38203

src/parser/xhpast/__tests__/data/base-pass.php.test

src/parser/xhpast/__tests__/data/call-time-pass-by-ref.php.test

src/parser/xhpast/__tests__/data/namespace.php.test

src/parser/xhpast/__tests__/data/operator-coalesce.php.test

src/parser/xhpast/__tests__/data/operator-spaceship-nonassoc.php.test

src/parser/xhpast/__tests__/data/operator-spaceship.php.test

src/parser/xhpast/__tests__/data/php-access-on-instanciation.test

src/parser/xhpast/__tests__/data/php-array-dereference-2.test

src/parser/xhpast/__tests__/data/php-array-dereference-3.test

src/parser/xhpast/__tests__/data/php-array-dereference.test

src/parser/xhpast/__tests__/data/php-binary-literal.php.test

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-comments.php.test

src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test

src/parser/xhpast/__tests__/data/php-finally.php.test

src/parser/xhpast/__tests__/data/php-literal-index.php.test

src/parser/xhpast/__tests__/data/php-literals.php.test

src/parser/xhpast/__tests__/data/php-only-finally.test

src/parser/xhpast/__tests__/data/php-short-array.php.test

src/parser/xhpast/__tests__/data/php-syntax.php.test

src/parser/xhpast/__tests__/data/php-tags.php.test

src/parser/xhpast/__tests__/data/php-traits.php.test

src/parser/xhpast/__tests__/data/php-yield.php.test

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/__tests__/data/use.php.test

src/parser/xhpast/__tests__/data/variadic.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

src/parser/xhpast/parser_tokens.php

support/xhpast/parser.y

support/xhpast/parser.yacc.hpp

support/xhpast/parser.yacc.cpp

support/xhpast/scanner.l

support/xhpast/scanner.lex.hpp

support/xhpast/scanner.lex.cpp

support/xhpast/xhpast.cpp

Add coalesce and spaceship operators to xhpast
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/base-pass.php.test

src/parser/xhpast/tests/data/call-time-pass-by-ref.php.test

src/parser/xhpast/tests/data/namespace.php.test

src/parser/xhpast/tests/data/operator-coalesce.php.test

src/parser/xhpast/tests/data/operator-spaceship-nonassoc.php.test

src/parser/xhpast/tests/data/operator-spaceship.php.test

src/parser/xhpast/tests/data/php-access-on-instanciation.test

src/parser/xhpast/tests/data/php-array-dereference-2.test

src/parser/xhpast/tests/data/php-array-dereference-3.test

src/parser/xhpast/tests/data/php-array-dereference.test

src/parser/xhpast/tests/data/php-binary-literal.php.test

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-comments.php.test

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

src/parser/xhpast/tests/data/php-finally.php.test

src/parser/xhpast/tests/data/php-literal-index.php.test

src/parser/xhpast/tests/data/php-literals.php.test

src/parser/xhpast/tests/data/php-only-finally.test

src/parser/xhpast/tests/data/php-short-array.php.test

src/parser/xhpast/tests/data/php-syntax.php.test

src/parser/xhpast/tests/data/php-tags.php.test

src/parser/xhpast/tests/data/php-traits.php.test

src/parser/xhpast/tests/data/php-yield.php.test

src/parser/xhpast/tests/data/return-type.php.test

src/parser/xhpast/tests/data/use.php.test

src/parser/xhpast/tests/data/variadic.php.test