Page MenuHomePhabricator

Write a simple parser to mangle `pygmentize` output to use email-friendly style attributes
ClosedPublic

Authored by epriestley on May 5 2016, 12:55 AM.
Tags
None
Referenced Files
F15454603: D15845.diff
Sat, Mar 29, 7:17 PM
F15445293: D15845.id.diff
Thu, Mar 27, 1:18 PM
F15438929: D15845.diff
Wed, Mar 26, 4:43 AM
F15428732: D15845.id.diff
Sun, Mar 23, 9:57 PM
F15403296: D15845.id38182.diff
Tue, Mar 18, 2:39 AM
Unknown Object (File)
Mon, Mar 3, 1:29 AM
Unknown Object (File)
Mon, Mar 3, 1:29 AM
Unknown Object (File)
Sat, Mar 1, 1:53 PM
Subscribers
None

Details

Summary

Ref T9790. This mangles pygmentize output so it does <span style="..."> instead of <span class="...">.

It doesn't use a regular expression, although it probably could.

I believe this is safe for all inputs, but it doesn't really matter: we'll only feed it safe inputs anyway, and it's only going to be used for email which we can't really do anything unsafe in.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
syntax1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12048
Build 15170: Run Core Tests
Build 15169: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38173.
epriestley retitled this revision from to Write a simple parser to mangle `pygmentize` output to use email-friendly style attributes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Pick less linty test data.
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2016, 1:31 AM
This revision was automatically updated to reflect the committed changes.