Page MenuHomePhabricator
Differential D15845

Write a simple parser to mangle `pygmentize` output to use email-friendly style attributes
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 12:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 11:03 AM
Unknown Object (File)
Fri, Apr 19, 4:36 PM
Unknown Object (File)
Wed, Apr 17, 7:33 PM
Unknown Object (File)
Sun, Apr 7, 4:42 PM
Unknown Object (File)
Mon, Apr 1, 5:11 PM
Unknown Object (File)
Sun, Mar 31, 7:37 PM
Unknown Object (File)
Fri, Mar 29, 10:25 AM
Unknown Object (File)
Fri, Mar 29, 10:25 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments
Commits
rPHU47fb41229851: Write a simple parser to mangle `pygmentize` output to use email-friendly…
Summary

Ref T9790. This mangles pygmentize output so it does <span style="..."> instead of <span class="...">.

It doesn't use a regular expression, although it probably could.

I believe this is safe for all inputs, but it doesn't really matter: we'll only feed it safe inputs anyway, and it's only going to be used for email which we can't really do anything unsafe in.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38172.May 5 2016, 12:55 AM
epriestley updated this revision to Diff 38173.
epriestley retitled this revision from to Write a simple parser to mangle `pygmentize` output to use email-friendly style attributes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
  • Pick less linty test data.
chad accepted this revision.May 5 2016, 1:31 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2016, 1:31 AM
Closed by commit rPHU47fb41229851: Write a simple parser to mangle `pygmentize` output to use email-friendly… (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 9:48 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 5 2016, 6:55 PM

Revision Contents
Changeset List

Diff 38182

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/parser/PhutilPygmentizeParser.php

Loading...
View Options

src/parser/__tests__/PhutilPygmentizeParserTestCase.php

Loading...
Phabricator · Built by Phacility