See D15678. A node containing a return type hint is added right before the statement body node. This updates all relevant linter rules to now retrieve the body from the correct index.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format
Ran arc unit --everything, inspected every single message to make sure all xhpast test cases succeeded. Also grepped for getChildByIndex(5 and getChildOfType(5.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- xhpast-return-types
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 11968 Build 15050: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 152 ms | ArcanistCppcheckLinterTestCase::Unknown Unit Message (" ") In 'zblair.lint-test', lint raised error on line 15 at char 0, but nothing was expected:
Mismatching allocation and deallocation: buf
| |
| 1,367 ms | ArcanistJSHintLinterTestCase::Unknown Unit Message (" ") In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised:
warning at line 3, char 8: W033 JSHintW033
error at line 7, char 1: E019 JSHintE019
| |
| 67 ms | ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 7 assertions passed. | |
| 28 ms | ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 3 assertions passed. | |
| 35 ms | ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 4 assertions passed. | |
| View Full Test Results (2 Failed · 120 Passed · 31 Skipped) |