Page MenuHomePhabricator
Differential D15789

Don't retry queries on connections holding global locks
ClosedPublic
Actions

Authored by epriestley on Apr 24 2016, 3:33 PM.
Tags
None
Referenced Files
F13059624: D15789.diff
Fri, Apr 19, 4:34 PM
Unknown Object (File)
Wed, Apr 17, 3:20 PM
Unknown Object (File)
Thu, Apr 11, 7:27 AM
Unknown Object (File)
Tue, Apr 9, 5:56 AM
Unknown Object (File)
Sun, Mar 31, 2:24 PM
Unknown Object (File)
Sun, Mar 31, 2:24 PM
Unknown Object (File)
Sun, Mar 31, 11:54 AM
Unknown Object (File)
Sun, Mar 31, 11:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10860: After an inconsistent cluster repository write, consider just ignoring the lock
Commits
rPHU4b44d03ba60c: Don't retry queries on connections holding global locks
Summary

Ref T10860. Currently, if we lose a connection that is holding a MySQL global lock, we may retry the query automatically.

Instead, we should abort, just like we do if we were in the middle of a transaction. Otherwise, code may still think it has the lock and do unsafe things.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Branch
lock-count
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11910
Build 14964: Run Core Tests
Build 14963: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38036.Apr 24 2016, 3:33 PM
epriestley retitled this revision from to Don't retry queries on connections holding global locks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10860: After an inconsistent cluster repository write, consider just ignoring the lock.
chad accepted this revision.Apr 24 2016, 4:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 24 2016, 4:09 PM
epriestley mentioned this in T10860: After an inconsistent cluster repository write, consider just ignoring the lock.Apr 24 2016, 6:39 PM
Closed by commit rPHU4b44d03ba60c: Don't retry queries on connections holding global locks (authored by epriestley, committed by epriestley). · Explain WhyApr 25 2016, 6:20 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 26 2016, 3:18 AM

Revision Contents
Changeset List

PathSize
src/
aphront/
storage/
connection/
43 lines
mysql/
14 lines

Diff 38036

View Options

src/aphront/storage/connection/AphrontDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Loading...
Phabricator · Built by Phacility